xiangfu0 commented on code in PR #14662:
URL: https://github.com/apache/pinot/pull/14662#discussion_r1919845535
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##########
@@ -241,6 +241,20 @@ public static Integer getGroupTrimThreshold(Map<String,
String> queryOptions) {
return uncheckedParseInt(QueryOptionKey.GROUP_TRIM_THRESHOLD,
groupByTrimThreshold);
}
+ @Nullable
+ public static Integer getNumThreadsForFinalReduce(Map<String, String>
queryOptions) {
+ String numThreadsForFinalReduceString =
queryOptions.get(QueryOptionKey.NUM_THREADS_FOR_FINAL_REDUCE);
+ return checkedParseInt(QueryOptionKey.NUM_THREADS_FOR_FINAL_REDUCE,
numThreadsForFinalReduceString, 1);
+ }
+
Review Comment:
Good point, update the estimated thread num to be between [1,
TRHEAD_POOL_SIZE]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
