gortiz commented on code in PR #14727:
URL: https://github.com/apache/pinot/pull/14727#discussion_r1905256128
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java:
##########
@@ -70,12 +74,12 @@ public BrokerResponseNative reduceOnDataTable(BrokerRequest
brokerRequest, Broke
queryOptions != null &&
Boolean.parseBoolean(queryOptions.get(CommonConstants.Broker.Request.TRACE));
ExecutionStatsAggregator aggregator = new
ExecutionStatsAggregator(enableTrace);
- BrokerResponseNative brokerResponseNative = new BrokerResponseNative();
+ BrokerResponseNative response = new BrokerResponseNative();
// Cache a data schema from data tables (try to cache one with data rows
associated with it).
- DataSchema dataSchemaFromEmptyDataTable = null;
- DataSchema dataSchemaFromNonEmptyDataTable = null;
- List<ServerRoutingInstance> serversWithConflictingDataSchema = new
ArrayList<>();
+ DataSchema schemaOfEmptyTable = null;
+ DataSchema schemaOfNonEmptyTable = null;
+ List<ServerRoutingInstance> serversWithConflictingSchema = new
ArrayList<>();
Review Comment:
I'm fine with a rename of the variables to make them easier to read, but
given they make this PR so difficult to read, I would encourage you to create
another PR with the renames
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
