gortiz commented on code in PR #14727:
URL: https://github.com/apache/pinot/pull/14727#discussion_r1905496077
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultistageGroupByExecutor.java:
##########
@@ -69,9 +70,16 @@ public class MultistageGroupByExecutor {
// because they use the zero based integer indexes to store results.
private final GroupIdGenerator _groupIdGenerator;
- public MultistageGroupByExecutor(int[] groupKeyIds, AggregationFunction[]
aggFunctions, int[] filterArgIds,
- int maxFilterArgId, AggType aggType, boolean leafReturnFinalResult,
DataSchema resultSchema,
- Map<String, String> opChainMetadata, @Nullable PlanNode.NodeHint
nodeHint) {
+ public MultistageGroupByExecutor(
+ int[] groupKeyIds,
+ AggregationFunction[] aggFunctions,
+ int[] filterArgIds,
+ int maxFilterArgId,
+ AggType aggType,
+ boolean leafReturnFinalResult,
+ DataSchema resultSchema,
+ Map<String, String> opChainMetadata,
+ @Nullable PlanNode.NodeHint nodeHint) {
Review Comment:
Some times you are using this format and sometimes you are using:
```java
public MultistageGroupByExecutor(int[] groupKeyIds,
AggregationFunction[] aggFunctions,
int[] filterArgIds,
int maxFilterArgId,
AggType aggType,
boolean leafReturnFinalResult,
DataSchema resultSchema,
Map<String, String> opChainMetadata,
@Nullable PlanNode.NodeHint nodeHint) {
```
I prefer what you are doing here, which is closer to the current style we
use in Pinot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
