noob-se7en commented on code in PR #14623:
URL: https://github.com/apache/pinot/pull/14623#discussion_r1925892001
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtimetoofflinesegments/RealtimeToOfflineSegmentsTaskExecutor.java:
##########
@@ -156,6 +162,11 @@ protected List<SegmentConversionResult>
convert(PinotTaskConfig pinotTaskConfig,
// Segment config
segmentProcessorConfigBuilder.setSegmentConfig(MergeTaskUtils.getSegmentConfig(configs));
+ // Since multiple subtasks run in parallel, there shouldn't be a name
conflict.
+ // Append uuid
+ segmentProcessorConfigBuilder.setSegmentNameGenerator(
Review Comment:
hmmm, Then we will have to add notes in documentations that this edge case
can occur and user should keep uuid based segmentNameGenerator. I think user
should not bother about this and Executor should handle this edge-case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
