noob-se7en commented on code in PR #14623:
URL: https://github.com/apache/pinot/pull/14623#discussion_r1925900499
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtimetoofflinesegments/RealtimeToOfflineSegmentsTaskGenerator.java:
##########
@@ -107,6 +115,8 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
LOGGER.info("Start generating task configs for table: {} for task: {}",
realtimeTableName, taskType);
// Only schedule 1 task of this type, per table
+ // Still there can be scenario where generator can generate additional
task, while previous task
+ // is just about to be enqueued in the helix queue.
Review Comment:
Let's say generator generated RTO tasks. The RTO task is just about to be
enqueued in the helix queue, But user schedules another RTO task, then there's
a race condition in this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
