RussellSpitzer commented on code in PR #154:
URL: https://github.com/apache/polaris/pull/154#discussion_r1730505655
##########
regtests/client/python/cli/polaris_cli.py:
##########
@@ -55,6 +67,27 @@ def execute(args=None):
PolarisCli._try_print_exception(e)
sys.exit(1)
+ @staticmethod
+ def _merge_with_config(options):
+ config = PolarisCli._load_config()
+ if not config:
+ return
+
+ for attr in ['client_id', 'client_secret', 'host', 'port']:
Review Comment:
Any reason why we want to allow-list only these props? Seems like we could
allow anything here for future proofing?
I assume we could just have something like
```python
for attr in config
If attr not in options
options[attr] = config[attr]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
