RussellSpitzer commented on code in PR #154:
URL: https://github.com/apache/polaris/pull/154#discussion_r1730506251
##########
regtests/client/python/cli/polaris_cli.py:
##########
@@ -55,6 +67,27 @@ def execute(args=None):
PolarisCli._try_print_exception(e)
sys.exit(1)
+ @staticmethod
+ def _merge_with_config(options):
+ config = PolarisCli._load_config()
+ if not config:
+ return
+
+ for attr in ['client_id', 'client_secret', 'host', 'port']:
+ if not getattr(options, attr) and config.get(attr):
+ setattr(options, attr, config[attr])
+
+ @staticmethod
+ def _load_config():
+ try:
+ with open(POLARIS_CLI_JSON, "r") as file:
Review Comment:
probably want to allow a cli arg like -c configFile as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
