sfc-gh-emaynard commented on code in PR #216:
URL: https://github.com/apache/polaris/pull/216#discussion_r1733341558
##########
polaris-service/src/test/java/io/polaris/service/catalog/PolarisSparkIntegrationTest.java:
##########
@@ -253,6 +257,20 @@ public void testCreateTable() {
assertThat(recordCount).isEqualTo(3);
}
+ @Test
Review Comment:
nit: new tests should probably go at the end of the file
##########
polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1143,12 +1143,19 @@ private class BasePolarisCatalogViewBuilder extends
BaseMetastoreViewCatalog.Bas
public BasePolarisCatalogViewBuilder(TableIdentifier identifier) {
super(identifier);
+ withProperties(viewDefaultProperties());
}
@Override
public ViewBuilder withLocation(String newLocation) {
return super.withLocation(transformTableLikeLocation(newLocation));
}
+
+ private Map<String, String> viewDefaultProperties() {
+ Map<String, String> viewDefaultProperties =
PropertyUtil.propertiesWithPrefix(BasePolarisCatalog.this.properties(),
"table-default.");
+ LOGGER.info("View properties set at catalog level through catalog
properties: {}", viewDefaultProperties);
Review Comment:
Let's make this a `DEBUG` log
##########
polaris-service/src/test/java/org/apache/polaris/service/catalog/PolarisSparkIntegrationTest.java:
##########
@@ -264,6 +268,20 @@ public void testCreateTable() {
assertThat(recordCount).isEqualTo(3);
}
+ @Test
Review Comment:
nit: new tests should probably go at the end of the file
##########
polaris-service/src/test/java/io/polaris/service/catalog/PolarisSparkIntegrationTest.java:
##########
@@ -253,6 +257,20 @@ public void testCreateTable() {
assertThat(recordCount).isEqualTo(3);
}
+ @Test
Review Comment:
nit: new tests should probably go at the end of the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
