eric-maynard commented on code in PR #216:
URL: https://github.com/apache/polaris/pull/216#discussion_r1733368737
##########
polaris-service/src/test/java/org/apache/polaris/service/catalog/PolarisSparkIntegrationTest.java:
##########
@@ -264,6 +268,20 @@ public void testCreateTable() {
assertThat(recordCount).isEqualTo(3);
}
+ @Test
Review Comment:
Totally agreed -- but this test to create a view is between a test for
creating a table and one for creating an external table.
It's not obvious to me that this keeps tests for the same entities together
any better than if the test for the view was moved to the end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
