espy commented on PR #9146:
URL: https://github.com/apache/pouchdb/pull/9146#issuecomment-3914492514
Hello! I've manually tested this on my machine, and it all works very well,
thank you for all the work. As far as I can tell, almost everything matches the
old site apart from some negligible syntax highlighting differences. I've only
found 2 issues that need resolving before merging:
1. Syntax highlighting in the `guide` section is off (left new, right old):
<img width="1680" height="553" alt="Bildschirmfoto 2026-02-17 um 13 12 53"
src="https://github.com/user-attachments/assets/1bb2a11a-d98b-432b-bdc1-071d77ff910e";
/>
Many of the guide pages don’t have code fences around some code snippets,
for example
[here](https://github.com/alxndrsn/pouchdb/blob/438ed3fb8d197821334d45a6747287adaacd6ca5/docs/guides/setup-couchdb.md?plain=1#L14),
and the `js` language declaration doesn’t seem to work (a few lines below the
previous link). These can both be resolved by [declaring the bg and text color
on the pre instead of the specific language
class](https://github.com/espy/pouchdb-actions-test/commit/7b1d7b7357684b1792f92411f13ae6b4d4b1b34c#diff-8ec59fc9e206b24275c9818a3299b1102e70e0c423b8b2497bee914ea3d21647),
and the `bash` blocks need to be [put inside code
fences](https://github.com/espy/pouchdb-actions-test/blob/2691e89c0e22d773598eeefe8b0b25f7c595c652/docs/guides/setup-couchdb.md?plain=1#L14-L16).
2. The site data now fetching stuff from `package.json` is cool, but the
`package.json` had the wrong `version` from the outset, it’s `"version":
"7.0.0-prerelease",` for some reason, and should be `9.0.0`.
With those two changes and the resolved conflicts, this seems good to go!
URLs all still work, ServiceWorker is serviceworking, the example PouchDB in
the dev tools console works… LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
