espy commented on PR #9146: URL: https://github.com/apache/pouchdb/pull/9146#issuecomment-3932804234
> @espy in your commit at [espy/pouchdb-actions-test@2691e89#diff-6744b4267bd2c2918dab97901f10b66cfffb1cff0dddd3c0fd01086f5294f3f0L3-R3](https://github.com/espy/pouchdb-actions-test/commit/2691e89c0e22d773598eeefe8b0b25f7c595c652#diff-6744b4267bd2c2918dab97901f10b66cfffb1cff0dddd3c0fd01086f5294f3f0L3-R3), you've reverted the change in liquid templates to add quotes around language names in `highlight` calls. Did this work without defining a global string `js = "js"`? If so it could considerably reduce the files touched by this PR. Yes, but I did also [switch to using eleventy’s syntax highlighting plugin](https://github.com/espy/pouchdb-actions-test/commit/c5396b15d21821b2d6c374efd59786137a049d38#diff-36a659af5021ea41791e1943be2d81d731ecac74eec458a97fc955a63751325c), that’s why that works. If I remember correctly that only required [minimal CSS changes](https://github.com/espy/pouchdb-actions-test/commit/7b1d7b7357684b1792f92411f13ae6b4d4b1b34c), some of which you also have already. Converting the indented code blocks to fenced ones was also my choice, in my experience being able to avoid significant whitespace like that is always a win 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
