jerrypeng commented on a change in pull request #3021: adding windowed metrics
for functions
URL: https://github.com/apache/pulsar/pull/3021#discussion_r235104150
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/FunctionsBase.java
##########
@@ -190,7 +190,7 @@ public Response getFunctionStatus(final
@PathParam("tenant") String tenant,
@ApiResponse(code = 403, message = "The requester doesn't have
admin permissions")
})
@Path("/{tenant}/{namespace}/{functionName}/stats")
- public Response getFunctionStats(final @PathParam("tenant") String tenant,
+ public FunctionStats getFunctionStats(final @PathParam("tenant") String
tenant,
Review comment:
FunctionsStats is not a protobuf object. 'getFunctionStats' use to return a
protobuf object I changed that in the previous PR. We should cleanup all REST
endpoints to not return a protobuf object
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
