srkukarni commented on a change in pull request #3324: Add Windowfunction interface to functions api URL: https://github.com/apache/pulsar/pull/3324#discussion_r247239113
########## File path: pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/WindowFunction.java ########## @@ -0,0 +1,34 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.functions.api; + +import java.util.Collection; + +/** + * This is the interface of the windowed function api. The process method is called + * for every triggered window. + */ +@FunctionalInterface +public interface WindowFunction<I, O> { + /** + * Process the input. + * @return the output + */ + O process(Collection<I> input, WindowContext context) throws Exception; Review comment: @jerrypeng as discussed, I've updated the interface to reflect our discussions. Please take a look again. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services