srkukarni commented on a change in pull request #3324: Add Windowfunction 
interface to functions api
URL: https://github.com/apache/pulsar/pull/3324#discussion_r247592146
 
 

 ##########
 File path: 
pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/WindowContext.java
 ##########
 @@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.pulsar.functions.windowing;
+package org.apache.pulsar.functions.api;
 
 Review comment:
   @sijie This is not api breaking change. Previously WindowContext was not 
exposed to the user at all. It was just implementation detail. Now we are 
exposing this.
   I will add up documentation as part of the another pr because there are 
other changes on top of this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to