ivankelly commented on a change in pull request #3677: PIP-30: interface and
mutual change authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r262437330
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -199,6 +200,24 @@ message CommandConnected {
optional int32 protocol_version = 2 [default = 0];
}
+message CommandAuthResponse {
+ required string client_version = 1;
+ required AuthData response = 2;
Review comment:
make response and challenge members optional. protobuf generally recommends
against making any fields required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
