ivankelly commented on a change in pull request #3677: PIP-30: interface and
mutual change authentication
URL: https://github.com/apache/pulsar/pull/3677#discussion_r262898126
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProvider.java
##########
@@ -60,22 +59,14 @@
*/
String authenticate(AuthenticationDataSource authData) throws
AuthenticationException;
Review comment:
Can you add a default here that throws an exception? This method is only
useful in onestage auth. The comment should say that, and by default (if you're
not doing onestage or if you're providing your own state implemenation for
onestage) it should throw an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
