michaeljmarshall commented on a change in pull request #14460:
URL: https://github.com/apache/pulsar/pull/14460#discussion_r814492037
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerServiceException.java
##########
@@ -77,12 +77,6 @@ public TopicClosedException(Throwable t) {
}
}
- public static class AddEntryMetadataException extends
BrokerServiceException {
Review comment:
I see that this isn't removed, we should deprecate the class.
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
##########
@@ -1525,11 +1525,6 @@ private static ByteBufPair
serializeCommandSendWithSize(BaseCommand cmd, Checksu
return command;
}
- public static ByteBuf addBrokerEntryMetadata(ByteBuf headerAndPayload,
Review comment:
What is the reason for removing this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
