315157973 opened a new pull request, #15425:
URL: https://github.com/apache/pulsar/pull/15425

   ### Motivation
   It is difficult to get CR due to so many modifications in PIP 81 #10729.
   So I split this PR into multiple sub-PRs to facilitate CR
   
   ### Modifications
   I split the logic in createNewMetadataLedger into multiple methods to 
facilitate subsequent reuse
   1. Put the logic of creating Ledger into `doCreateNewMetadataLedger` 
separately
   2. `switchToNewLedger` does not need to wrap another layer of callback, so 
remove redundant wrapping
   3. When persisting data fails, we need to delete the created Ledger, this 
part of the logic is put into `deleteLedger`
   
   ### Verifying this change
   This modification does not change any previous behavior, so no unit tests 
are required, but the previous unit tests must be ensured to pass
   
   ### Documentation
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `no-need-doc` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-added`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to