mattisonchao commented on code in PR #15425:
URL: https://github.com/apache/pulsar/pull/15425#discussion_r866609933
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2532,10 +2532,45 @@ void internalFlushPendingMarkDeletes() {
void createNewMetadataLedger(final VoidCallback callback) {
ledger.mbean.startCursorLedgerCreateOp();
+ doCreateNewMetadataLedger().thenAccept(newLedgerHandle -> {
+ if (newLedgerHandle == null) {
+ return;
+ }
+ MarkDeleteEntry mdEntry = lastMarkDeleteEntry;
+ // Created the ledger, now write the last position content
+ persistPositionToLedger(newLedgerHandle, mdEntry, new
VoidCallback() {
+ @Override
+ public void operationComplete() {
+ if (log.isDebugEnabled()) {
+ log.debug("[{}] Persisted position {} for cursor {}",
ledger.getName(),
+ mdEntry.newPosition, name);
+ }
+ switchToNewLedger(newLedgerHandle, callback);
+ }
+
+ @Override
+ public void operationFailed(ManagedLedgerException exception) {
+ log.warn("[{}] Failed to persist position {} for cursor
{}", ledger.getName(),
+ mdEntry.newPosition, name);
+
+ deleteLedgerAsync(newLedgerHandle);
+ callback.operationFailed(exception);
+ }
+ });
+ }).whenComplete((result, e) -> {
+ ledger.mbean.endCursorLedgerCreateOp();
+ if (e != null) {
+ callback.operationFailed(createManagedLedgerException(e));
+ }
+ });
+ }
+ private CompletableFuture<LedgerHandle> doCreateNewMetadataLedger() {
+ CompletableFuture<LedgerHandle> future = new CompletableFuture<>();
ledger.asyncCreateLedger(bookkeeper, config, digestType, (rc, lh, ctx)
-> {
if (ledger.checkAndCompleteLedgerOpTask(rc, lh, ctx)) {
+ future.complete(null);
Review Comment:
Sorry, I missed the folding code for GH. Although I think it should be
possible to optimize, there are too many race conditions here. It's best not to
change the logic.
Very thanks for your patient answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
