eolivelli commented on code in PR #15757:
URL: https://github.com/apache/pulsar/pull/15757#discussion_r881379343
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentSubscription.java:
##########
@@ -526,4 +526,15 @@ public void updateLastActive() {
public Map<String, String> getSubscriptionProperties() {
return subscriptionProperties;
}
+
+ @Override
+ public CompletableFuture<Void> updateSubscriptionProperties(Map<String,
String> subscriptionProperties) {
+ if (subscriptionProperties == null) {
Review Comment:
there is not much difference
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -1094,6 +1094,20 @@ public Map<String, String> getSubscriptionProperties() {
return subscriptionProperties;
}
+ @Override
+ public CompletableFuture<Void> updateSubscriptionProperties(Map<String,
String> subscriptionProperties) {
+ Map<String, String> newSubscriptionProperties;
+ if (subscriptionProperties == null) {
Review Comment:
there is not much difference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
