lhotari commented on code in PR #15757:
URL: https://github.com/apache/pulsar/pull/15757#discussion_r882458839
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -1094,6 +1093,20 @@ public Map<String, String> getSubscriptionProperties() {
return subscriptionProperties;
}
+ @Override
+ public CompletableFuture<Void> updateSubscriptionProperties(Map<String,
String> subscriptionProperties) {
+ Map<String, String> newSubscriptionProperties;
+ if (subscriptionProperties == null ||
subscriptionProperties.isEmpty()) {
+ newSubscriptionProperties = Collections.emptyMap();
+ } else {
+ newSubscriptionProperties =
Collections.unmodifiableMap(subscriptionProperties);
+ }
+ return cursor.setCursorProperties(newSubscriptionProperties)
+ .thenRun(() -> {
+ this.subscriptionProperties = newSubscriptionProperties;
Review Comment:
Are there any thread safety considerations here? Would it be required to
make subscriptionProperties a volatile field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
