poorbarcode commented on code in PR #16685:
URL: https://github.com/apache/pulsar/pull/16685#discussion_r926396262
##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionLogImpl.java:
##########
@@ -233,6 +289,28 @@ public void start() {
}
}
+ public static List<TransactionMetadataEntry> deserializeEntry(ByteBuf
buffer){
+ // Check whether it is batched Entry.
+ buffer.markReaderIndex();
+ short magicNum = buffer.readShort();
+ buffer.resetReaderIndex();
+ if (magicNum == BATCHED_ENTRY_DATA_PREFIX_MAGIC_NUMBER){
+ // skip version
+ buffer.skipBytes(4);
+ BatchedTransactionMetadataEntry batchedLog = new
BatchedTransactionMetadataEntry();
+ batchedLog.parseFrom(buffer, buffer.readableBytes());
+ return batchedLog.getTransactionLogsList();
+ } else {
+ TransactionMetadataEntry log = new TransactionMetadataEntry();
+ log.parseFrom(buffer, buffer.readableBytes());
+ return Collections.singletonList(log);
+ }
+ }
+
+ public static List<TransactionMetadataEntry> deserializeEntry(Entry entry){
+ return deserializeEntry(entry.getDataBuffer());
Review Comment:
No. It will be released in `TransactionLogReplayer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
