poorbarcode commented on code in PR #16685:
URL: https://github.com/apache/pulsar/pull/16685#discussion_r926504867
##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnBatchedPositionImpl.java:
##########
@@ -56,4 +61,19 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(super.hashCode(), batchSize, batchIndex);
}
+
+ /**
+ * Build the attribute ackSet to that {@link #batchIndex} is false and
others is true.
+ */
+ public void deleteFromAckSet(){
Review Comment:
Good idea. A bug was found by adding this unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
