BewareMyPower opened a new pull request, #45: URL: https://github.com/apache/pulsar-client-cpp/pull/45
### Motivation The `docker-build.sh` cannot build this library because the code format check failed. The reason is that the Docker image's `clang-format` version is 10.0.0, while the default clang-format version of Ubuntu-20.04 is 11.0.0-2~ubuntu20.04.1. ### Modifications Fix the format check by running `docker-format.sh`. For the CI, configure `-DCLANG_FORMAT_VERSION=10` so that CMake will find `/usr/bin/clang-format-10` instead of the default `clang-format`. Modify the documents to note that the repo uses clang-format 10.0.0. I also found another file `gf2.hpp` is not well formatted because the suffix is `*.hpp`, which cannot be found by CMake. Simply change the suffix to `*.h`. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [ ] `doc-not-needed` (Please explain why) - [x] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
