AnonHxy commented on code in PR #18212:
URL: https://github.com/apache/pulsar/pull/18212#discussion_r1006451057
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerStatsDisabled.java:
##########
@@ -145,7 +146,12 @@ public void reset() {
}
@Override
- public void updateCumulativeStats(ConsumerStats stats) {
+ public void updateCumulativeStats(String partition, ConsumerStats stats) {
Review Comment:
1. If we change the method singuture, I'm not sure will it bring some
compatible problem, because this method is public.
2. The name of this method is `updateCumulativeStats`, doing some
partitioned stats work is not `cumulative` I think. How about add a new method
like `updatePartitionedStats()` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
