rdhabalia commented on code in PR #18212:
URL: https://github.com/apache/pulsar/pull/18212#discussion_r1007168628
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerStatsDisabled.java:
##########
@@ -145,7 +146,12 @@ public void reset() {
}
@Override
- public void updateCumulativeStats(ConsumerStats stats) {
+ public void updateCumulativeStats(String partition, ConsumerStats stats) {
Review Comment:
this method is only used by partitioned topic stats only and it's not part
of public interface and used by internal Impl class only with single thread.
so, there is no issue in changing the signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
