WJL3333 commented on code in PR #18357:
URL: https://github.com/apache/pulsar/pull/18357#discussion_r1016161398
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/collections/ConcurrentOpenLongPairRangeSet.java:
##########
@@ -220,6 +222,35 @@ public void forEach(RangeProcessor<T> action,
LongPairConsumer<? extends T> cons
});
}
+ @Override
+ public <O> void forEachWithRangeBoundMapper(LongPairConsumer<O>
rawRangeBoundMapper,
Review Comment:
thanks for review. the generic for range require for `<T extands
Comparable<T>>` which is used in `Range<T>` but for iteration ops we may
transform to non Comparable object. i try to reuse but we need the
`MLDataFormats.MessageRange` implements `Comparable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
