WJL3333 commented on code in PR #18357:
URL: https://github.com/apache/pulsar/pull/18357#discussion_r1020776182
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2839,20 +2839,30 @@ private List<MLDataFormats.MessageRange>
buildIndividualDeletedMessageRanges() {
MLDataFormats.MessageRange.Builder messageRangeBuilder =
MLDataFormats.MessageRange.newBuilder();
AtomicInteger acksSerializedSize = new AtomicInteger(0);
List<MessageRange> rangeList = new ArrayList<>();
- individualDeletedMessages.forEach((positionRange) -> {
- PositionImpl p = positionRange.lowerEndpoint();
- nestedPositionBuilder.setLedgerId(p.getLedgerId());
- nestedPositionBuilder.setEntryId(p.getEntryId());
-
messageRangeBuilder.setLowerEndpoint(nestedPositionBuilder.build());
- p = positionRange.upperEndpoint();
- nestedPositionBuilder.setLedgerId(p.getLedgerId());
- nestedPositionBuilder.setEntryId(p.getEntryId());
-
messageRangeBuilder.setUpperEndpoint(nestedPositionBuilder.build());
- MessageRange messageRange = messageRangeBuilder.build();
- acksSerializedSize.addAndGet(messageRange.getSerializedSize());
- rangeList.add(messageRange);
- return rangeList.size() <=
config.getMaxUnackedRangesToPersist();
- });
+
+ individualDeletedMessages.forEachWithRangeBoundMapper(
Review Comment:
Nice suggestion ! I have done coding. please take a look again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
