tisonkun commented on code in PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#discussion_r1041521017


##########
pom.xml:
##########
@@ -109,6 +109,9 @@ flexible messaging model and an intuitive client 
API.</description>
     <testRetryCount>1</testRetryCount>
     <testJacocoAgentArgument/>
     <testHeapDumpPath>/tmp</testHeapDumpPath>
+    <!-- This property is used to generate reproducible builds. We do not use 
it, but we do not want to inherit
+    this time property from dependencies. By setting it to null, we get "now" 
as the build time. -->
+    <project.build.outputTimestamp></project.build.outputTimestamp>

Review Comment:
   ```suggestion
       <project.build.outputTimestamp>10</project.build.outputTimestamp>
   ```
   
   https://github.com/tisonkun/pulsar/pull/21 It seems this change can make the 
SQL tests passed now.
   
   The config is copied from 
https://maven.apache.org/guides/mini/guide-reproducible-builds.html.
   
   I'm trying locally to see if the timestamp is correctly resolved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to