tisonkun commented on code in PR #17754:
URL: https://github.com/apache/pulsar/pull/17754#discussion_r1041542158
##########
pom.xml:
##########
@@ -109,6 +109,9 @@ flexible messaging model and an intuitive client
API.</description>
<testRetryCount>1</testRetryCount>
<testJacocoAgentArgument/>
<testHeapDumpPath>/tmp</testHeapDumpPath>
+ <!-- This property is used to generate reproducible builds. We do not use
it, but we do not want to inherit
+ this time property from dependencies. By setting it to null, we get "now"
as the build time. -->
+ <project.build.outputTimestamp></project.build.outputTimestamp>
Review Comment:
It seems force the timestamp to a past time is less than awesome, although
the property can be updated on release.
Another possible cause is that we don't update the property in `buildtools`
also, as well as we have some plugins that conflict with reproducible build
(detected by `mvn artifact:check-buildplan `.
I'll debug on https://github.com/tisonkun/pulsar/pull/21 to find a good way
while SQL tests keep failing on this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
