BewareMyPower commented on code in PR #139:
URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1062256415
##########
lib/ConsumerImpl.cc:
##########
@@ -527,6 +544,10 @@ void ConsumerImpl::messageReceived(const
ClientConnectionPtr& cnx, const proto::
<< startMessageId.value());
return;
}
+ if (redeliveryCount >= deadLetterPolicy_.getMaxRedeliverCount()) {
+ possibleSendToDeadLetterTopicMessages_.emplace(m.getMessageId(),
std::vector<Message>{m});
+ increaseAvailablePermits(cnx);
Review Comment:
If the redeliver logic needs extra tests. We can add a TODO here and add the
tests in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
