BewareMyPower commented on code in PR #139:
URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1071930114
##########
include/pulsar/ConsumerConfiguration.h:
##########
@@ -554,6 +593,8 @@ class PULSAR_PUBLIC ConsumerConfiguration {
bool isStartMessageIdInclusive() const;
friend class PulsarWrapper;
+ friend class DeadLetterQueueTest;
+ friend class
DeadLetterQueueTest_testWithoutConsumerReceiveImmediately_Test;
Review Comment:
Could you replace them with `PulsarFriend` and add some methods to
`PulsarFriend` to access private fields of `ConsumerConfiguration`? Once the
test name changed, these friend classes would be meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
