eolivelli commented on code in PR #19374:
URL: https://github.com/apache/pulsar/pull/19374#discussion_r1092224072
##########
pulsar-common/src/main/java/org/apache/pulsar/common/naming/SystemTopicNames.java:
##########
@@ -81,7 +81,7 @@ public static boolean isTopicPoliciesSystemTopic(String
topic) {
if (topic == null) {
return false;
}
- return
TopicName.get(topic).getLocalName().equals(NAMESPACE_EVENTS_LOCAL_NAME);
+ return
TopicName.get(topic).getLocalName().startsWith(NAMESPACE_EVENTS_LOCAL_NAME);
Review Comment:
This is strange.
it means that sometimes we call this function on the logical name of the
partitioned topic and sometimes on a partition.
are we changing the behavior ?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java:
##########
@@ -246,9 +246,6 @@ protected void updateTopicPolicyByNamespacePolicy(Policies
namespacePolicies) {
if (log.isDebugEnabled()) {
log.debug("[{}]updateTopicPolicyByNamespacePolicy,data={}", topic,
namespacePolicies);
}
- if (namespacePolicies.deleted) {
Review Comment:
with https://github.com/apache/pulsar/pull/19097 we will be sure that
"namespacePolicies.deleted" is authoritative.
if we are deleting the namespace then we should do nothing
cc @dlg99 @aymkhalil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
