dlg99 commented on PR #19374: URL: https://github.com/apache/pulsar/pull/19374#issuecomment-1411264444
@mattisonchao what's happening in this PR as I understand: 1. delete all topics + all system topics except for the events one. 2. Then delete the events topic 3. but that brings in some problems with handling of ns.deleted metadata (because of rpc?) so let's remove that logic in some places. This does not sound like a comprehensive solution (can't topic creation happen after p.2 and still cause namespace deletion to fail?) plus it breaks contract for handling of ns.deleted as @eolivelli moted. On another note, events topic is being deleted using `admin.topics().deletePartitionedTopicAsync` while for other partitioned topics we use `namespaceResources().getPartitionedTopicResources().deletePartitionedTopicAsync` (in internalDeletePartitionedTopicsAsync). Is it done on purpose? I'd leave ns.deleted handling logic as it is, set ns.deleted for namespace earlier before actually listing topics (seems to be the right thing to do logically). Do the rest of the steps with retries/backoff - ns is marked as deleted so topic creations should settle at some point. List topics again and delete again. then delete the namespace metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
