eolivelli commented on code in PR #19374:
URL: https://github.com/apache/pulsar/pull/19374#discussion_r1092859190
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -248,9 +245,8 @@ protected CompletableFuture<Void>
internalDeleteNamespaceAsync(boolean force) {
hasNonSystemTopic = true;
allUserCreatedPartitionTopics.add(topic);
} else {
- if
(SystemTopicNames.isTopicPoliciesSystemTopic(topic)) {
- partitionedTopicPolicy.add(topic);
- } else {
+ if (!TopicName.get(topic).getLocalName()
+
.startsWith(SystemTopicNames.NAMESPACE_EVENTS_LOCAL_NAME)) {
Review Comment:
can we create an utility method in SystemTopicNames ?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java:
##########
@@ -246,9 +246,6 @@ protected void updateTopicPolicyByNamespacePolicy(Policies
namespacePolicies) {
if (log.isDebugEnabled()) {
log.debug("[{}]updateTopicPolicyByNamespacePolicy,data={}", topic,
namespacePolicies);
}
- if (namespacePolicies.deleted) {
Review Comment:
I have checked the code again.
We can keep this change, it is harmless, the topic is deemed to be deleted,
we can allow the policy to be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
