RobertIndie commented on code in PR #20435:
URL: https://github.com/apache/pulsar/pull/20435#discussion_r1217842490
##########
docker/pulsar-all/pom.xml:
##########
@@ -125,6 +125,29 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>pl.project13.maven</groupId>
+ <artifactId>git-commit-id-plugin</artifactId>
+ <version>${git-commit-id-plugin.version}</version>
+ <executions>
+ <execution>
+ <id>git-info</id>
+ <goals>
+ <goal>revision</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <useNativeGit>true</useNativeGit>
+ <prefix>git</prefix>
+ <failOnNoGitDirectory>true</failOnNoGitDirectory>
Review Comment:
If you don't set it to false, it will be unable to resolve
`${git.commit.id.abbrev}`.
But I use a simple way to enable it to build the image without the git
directory. The image name will be like `apachepulsar/pulsar:3.1.0-no-git`. We
can further improve it with another PR if you have a better idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
