lhotari commented on code in PR #20435:
URL: https://github.com/apache/pulsar/pull/20435#discussion_r1217877781
##########
pom.xml:
##########
@@ -1571,6 +1571,31 @@ flexible messaging model and an intuitive client
API.</description>
</executions>
</plugin>
+ <plugin>
+ <groupId>pl.project13.maven</groupId>
+ <artifactId>git-commit-id-plugin</artifactId>
+ <version>${git-commit-id-plugin.version}</version>
+ <executions>
+ <execution>
+ <id>git-info</id>
+ <goals>
+ <goal>revision</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <skip>true</skip>
Review Comment:
Just thinking whether `pulsar-common`'s usage of `git-commit-id-plugin`
continues to work as expected. It should since by default all configuration is
replaced if it's defined in a child pom.xml?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
