RobertIndie opened a new pull request, #167: URL: https://github.com/apache/pulsar-dotpulsar/pull/167
Fixes #166 # Description The root cause of #166 is that the PingPongHandler doesn't work expectedly. The expected behavior for PingPongHandler is as follows: - Send a ping every keepAliveIntervarl(default is 30s) - Waiting for the Pong responses or any other command. - Trigger the Watch task at the next keepAliveIntervarl. If there are no incoming commands in this period. Then the connection is dead, and we should dispose the connection. But the current behavior is Triigger the Watch every keepAliveIntervarl. If there are o incoming commands, then send the Ping. And there are any actions to the connection. # Regression It's not a regression. # Testing It seems hard to add a test for it. But I have tested it that it could fix #166 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
