blankensteiner commented on code in PR #167:
URL: https://github.com/apache/pulsar-dotpulsar/pull/167#discussion_r1301505115
##########
src/DotPulsar/Internal/Connection.cs:
##########
@@ -336,6 +338,14 @@ public async ValueTask DisposeAsync()
await _stream.DisposeAsync().ConfigureAwait(false);
}
+ public async void MarkInactive()
Review Comment:
Point taken, but it is the ConnectionPool that creates the connections and
should be the one disposing them. Splitting lifecycle management is an issue
and especially if classes owned by the connection kill the connection. An
alternative is for the connection to expose a Task that completes if a timeout
occurs. The ConnectionPool can have those tasks in the wait loop when checking
inactive connections. Make sense and up for that? Otherwise, I currently have
time to implement this, if you are busy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
