codelipenghui commented on code in PR #22019:
URL: https://github.com/apache/pulsar/pull/22019#discussion_r1477195822
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpScan.java:
##########
@@ -128,7 +128,7 @@ public void find() {
}
if (cursor.hasMoreEntries(searchPosition)) {
OpReadEntry opReadEntry = OpReadEntry.create(cursor,
searchPosition, batchSize,
- this, OpScan.this.ctx, null, null);
+ this, OpScan.this.ctx, null, null, false);
Review Comment:
Instead of adding more complexity to the original entry reads. I think we
can have a separate non-durable cursor to do the scanning. The original cursor
(users' subscription) just provided a start position and the entry filter of
the scanning task.
And it will provide good observability for the scanning task. You can get
the non-durable cursor stats from the topic's internal-stats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
