gaoran10 commented on code in PR #22019:
URL: https://github.com/apache/pulsar/pull/22019#discussion_r1477235890
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -530,111 +530,132 @@ public String getTypeString() {
return "Null";
}
- @Override
public CompletableFuture<AnalyzeBacklogResult>
analyzeBacklog(Optional<Position> position) {
+ final ManagedLedger managedLedger = topic.getManagedLedger();
+ try {
Review Comment:
Maybe we don't need to try-catch the entire method?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -530,111 +530,132 @@ public String getTypeString() {
return "Null";
}
- @Override
public CompletableFuture<AnalyzeBacklogResult>
analyzeBacklog(Optional<Position> position) {
+ final ManagedLedger managedLedger = topic.getManagedLedger();
+ try {
Review Comment:
Maybe we don't need to try-catch the entire method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
