lhotari commented on code in PR #22139:
URL: https://github.com/apache/pulsar/pull/22139#discussion_r1505447660
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -157,7 +158,8 @@ public PersistentSubscription(PersistentTopic topic, String
subscriptionName, Ma
this.subscriptionProperties = MapUtils.isEmpty(subscriptionProperties)
? Collections.emptyMap() :
Collections.unmodifiableMap(subscriptionProperties);
if
(topic.getBrokerService().getPulsar().getConfig().isTransactionCoordinatorEnabled()
- && !isEventSystemTopic(TopicName.get(topicName))) {
+ && !isEventSystemTopic(TopicName.get(topicName))
+ && !ExtensibleLoadManagerImpl.isInternalTopic(topicName)) {
Review Comment:
We have also `SystemTopicNames`:
https://github.com/apache/pulsar/blob/9918bced4465e0b0746a7959550c90cb76ae945f/pulsar-common/src/main/java/org/apache/pulsar/common/naming/SystemTopicNames.java#L71-L97
As you can see, it's not consistent. The `isSystemTopic` method isn't an
intersection of all the possible subtypes.
And we also have the `Topic.isSystemTopic` method which is another way and
not consistent.
This mess should be cleaned up or at least not made worse...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
