lhotari commented on code in PR #22139:
URL: https://github.com/apache/pulsar/pull/22139#discussion_r1506384701
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -157,7 +158,8 @@ public PersistentSubscription(PersistentTopic topic, String
subscriptionName, Ma
this.subscriptionProperties = MapUtils.isEmpty(subscriptionProperties)
? Collections.emptyMap() :
Collections.unmodifiableMap(subscriptionProperties);
if
(topic.getBrokerService().getPulsar().getConfig().isTransactionCoordinatorEnabled()
- && !isEventSystemTopic(TopicName.get(topicName))) {
+ && !isEventSystemTopic(TopicName.get(topicName))
+ && !ExtensibleLoadManagerImpl.isInternalTopic(topicName)) {
Review Comment:
We had a discussion about this and in the short term, this could be done,
but in the long term, we need a proper solution for system topics. @asafm
suggested a modular solution where different "plugins" would register their
system topic rules to a system topic manager etc. . This sounds like a useful
long term solution to the problem.
We discussed that SystemTopicNames cannot reference the
ExtensibleLoadManagerImpl and that's why moving the method call there isn't
possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
