thetumbled commented on code in PR #22452: URL: https://github.com/apache/pulsar/pull/22452#discussion_r1560357164
########## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java: ########## @@ -674,6 +700,10 @@ private void closeReader(SystemTopicClient.Reader<TransactionBufferSnapshot> rea } } + public interface MaxReadPositionCallBack { + void moveForward(PositionImpl oldPosition, PositionImpl newPosition); Review Comment: I have changed the method name and complete the documents, PTAL, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org