thetumbled commented on PR #22452: URL: https://github.com/apache/pulsar/pull/22452#issuecomment-2048840477
> > * update `lastDataMessagePublishedTimestamp` when the max position move forward. > > this seems to make sense. assuming that "when the max position moves forward", there are more messages available to be read. It might make sense to rename `lastDataMessagePublishedTimestamp` to cover both the non-tranactional and tranactional case. The field name should also include the purpose, this is for replicated subscriptions. It's also possible to cover the meaning in a code comment for the field. good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
