rdhabalia commented on PR #22535: URL: https://github.com/apache/pulsar/pull/22535#issuecomment-2065335883
@merlimat @lhotari I have changed one of the test behavior in the last commit. With previous broker version: namespace policy (eg: `maxUnackMessagesPerSubscription`) default value in metadata was <= 0 . It means if broker sees `maxUnackMessagesPerSubscription=-1` in the namespace policy metadata then broker was falling back to broker's configuration which is 200K. However, after TopicPolicy Implementation, it broke the expectation and if it sees policy value <=0, then it won't restrict. and that was also implemented as a part of the test `AdminApiTest2::testMaxConsumersPerTopicUnlimited` which I had to change. can you please take a look change and we can merge the PR if there are no concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
