rdhabalia commented on PR #22535: URL: https://github.com/apache/pulsar/pull/22535#issuecomment-2065405134
I found many tests which are having above behavior where if namespace-policy value is 0 then it means broker should override 0 value over broker-config and disable all restrictions. Therefore, as a common ground, I am making change to normalize `-1` value for namespace-policy as fallback to broker-config. and `0` means override namespace-config value and disable all restrictions. that will not require to make any test changes and will mostly address old version compatibility for at least few configurations: `max_unacked_messages_per_consumer, max_unacked_messages_per_subscription` because these config had default value `-1` where as below config will be still impacted as earlier version had their default value `0` `max_producers_per_topic,max_consumers_per_topic,max_consumers_per_subscription` Old Release policies https://github.com/apache/pulsar/blob/branch-2.6/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/Policies.java So, Users running old Pulsar release must update namespace policy manually with `-1` for below policies before upgrading version to avoid breaking policy changes `max_producers_per_topic,max_consumers_per_topic,max_consumers_per_subscription` So, with current PR, it will not break current new behavior and will still address the default behavior for policies `max_unacked_messages_per_consumer, max_unacked_messages_per_subscription`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
