shasank112001 commented on code in PR #22692:
URL: https://github.com/apache/pulsar/pull/22692#discussion_r1596912566
##########
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java:
##########
@@ -89,8 +90,7 @@ private String getFloatValue(float size) {
return String.valueOf(r.nextFloat());
}
String format = "%" + size + "f";
-
- return String.format(format, get_FloatValue(size));
+ return String.format(Locale.US, format, get_FloatValue(size));
Review Comment:
When I ran the tests on my machine the floating point numbers were being
formatted with a comma instead of a decimal. It might have something to do with
my machine having the default locale on the system as Europe, so I thought it
would be best to make sure that US Locale is used, as JSON strings won't work
with , separated floating point numbers.
I am open to other suggestions, or reverting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
