shasank112001 commented on code in PR #22692:
URL: https://github.com/apache/pulsar/pull/22692#discussion_r1596940014
##########
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceBaseArguments.java:
##########
@@ -49,6 +49,31 @@ public abstract class PerformanceBaseArguments extends
CmdBase{
descriptionKey = "tlsTrustCertsFilePath")
public String tlsTrustCertsFilePath = "";
+ @Option(names = {"--use-keystore-tls" }, description = "Use KeyStore TLS",
descriptionKey = "useKeyStoreTls")
+ public Boolean useKeyStoreTls = null;
Review Comment:
I have updated it based on your suggestion. Using primitive types was also
my intuition, but all other booleans in this class are using a boolean object,
so I thought it would be good for consistency. Do you think, the other booleans
for tlsAllowInsecureConnection and tlsHostnameVerificationEnable should also be
changed to primitive type to be able to get rid of the null checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
