poorbarcode commented on code in PR #23088:
URL: https://github.com/apache/pulsar/pull/23088#discussion_r1694487960
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -1201,6 +1203,21 @@ public long estimateBacklogSize() {
}
public SubscriptionStatsImpl getStats(GetStatsOptions getStatsOptions) {
+ // So far, there is no case hits this check.
+ if (getStatsOptions.isGetEarliestTimeInBacklog()) {
+ throw new IllegalArgumentException("Calling the sync method
subscription.getStats with"
+ + " getEarliestTimeInBacklog, it may encountered a
deadlock error.");
+ }
+ // The method "getStatsAsync" will be a sync method if the param
"isGetEarliestTimeInBacklog" is false.
+ try {
+ return getStatsAsync(getStatsOptions).get(5, TimeUnit.SECONDS);
Review Comment:
> Maybe we should use get() instead of get(5, TimeUnit.SECONDS)?
Both are OK, because it will be completed immediately. And `get(5,
TimeUnit.SECONDS)` will release the deadlock after timeout, but `get()` will not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
